fix: Keycloak theme QA nits from PR #130 #208

Merged

forgejo_admin merged 1 commit from 131-keycloak-theme-polish into main

2026-03-27 22:04:22 +00:00

forgejo_admin commented

2026-03-27 22:01:58 +00:00

Owner

Summary

Addresses 4 CSS/infra polish items discovered during QA review of PR #130 (Westside Keycloak login theme). All hex values now trace to westside-app design tokens, border renders as red top only, font size uses rem, and dev-only cache flags are documented.

Changes

keycloak/themes/westside/login/resources/css/westside.css — Replace off-palette #1a1a1a hover with #262626 (--color-gray-800); remove redundant border-color that made all card sides red (intent was top-only); convert 29px magic number to 1.8125rem
terraform/modules/keycloak/main.tf — Document dev-only --spi-theme-static-max-age=-1 and --spi-theme-cache-themes=false with TODO(production) comment

Test Plan

tofu validate passes
Visual: no regression expected — hover color is slightly lighter than before (on-palette), border change removes unintended red side borders, font size is identical rendered value
Cache flags are unchanged functionally (comment-only change)

Review Checklist

No off-palette colors — all hex values traceable to westside-app design tokens
Border renders as red top only, not red all sides
Font size uses rem units
Cache flags documented with TODO(production)
tofu validate passes
No unrelated changes committed

Plan: plan-wkq Phase 15
Parent PR: #130

Closes #131

## Summary Addresses 4 CSS/infra polish items discovered during QA review of PR #130 (Westside Keycloak login theme). All hex values now trace to westside-app design tokens, border renders as red top only, font size uses rem, and dev-only cache flags are documented. ## Changes - `keycloak/themes/westside/login/resources/css/westside.css` — Replace off-palette `#1a1a1a` hover with `#262626` (--color-gray-800); remove redundant `border-color` that made all card sides red (intent was top-only); convert `29px` magic number to `1.8125rem` - `terraform/modules/keycloak/main.tf` — Document dev-only `--spi-theme-static-max-age=-1` and `--spi-theme-cache-themes=false` with TODO(production) comment ## Test Plan - `tofu validate` passes - Visual: no regression expected — hover color is slightly lighter than before (on-palette), border change removes unintended red side borders, font size is identical rendered value - Cache flags are unchanged functionally (comment-only change) ## Review Checklist - [x] No off-palette colors — all hex values traceable to westside-app design tokens - [x] Border renders as red top only, not red all sides - [x] Font size uses rem units - [x] Cache flags documented with TODO(production) - [x] `tofu validate` passes - [x] No unrelated changes committed ## Related Notes - Plan: `plan-wkq` Phase 15 - Parent PR: #130 Closes #131

forgejo_admin added 1 commit

2026-03-27 22:01:58 +00:00

fix: Keycloak theme QA nits — palette, border, rem units, cache docs

ci/woodpecker/push/woodpecker Pipeline was successful

Details

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful

Details

db365db04e

Address 4 polish items from PR #130 QA review:
- Replace off-palette #1a1a1a hover with #262626 (--color-gray-800)
- Remove redundant border-color that made all sides red (intent: top only)
- Convert 29px magic number to 1.8125rem
- Document dev-only cache flags with TODO(production)

Closes #131

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-27 22:03:01 +00:00

Author

Owner

QA Review — PR #208

Acceptance Criteria Check (from issue #131)

Criteria	Status	Notes
No off-palette colors	PASS	All hex values traceable to design tokens in header comment. `#1a1a1a` replaced with `#262626` (--color-gray-800).
Border renders as red top only	PASS	Redundant `border-color: #d42026` removed. Only `border-top: 4px solid #d42026` remains.
Font size uses rem units	PASS	`29px` converted to `1.8125rem` with conversion comment.
Cache flags documented	PASS	TODO(production) comment added with explanation of each flag. Flags left functional — consistent with issue constraint ("removal may be deferred").

Diff Review

2 files changed, +6/-4 lines. Minimal, focused diff — no unrelated changes.
CSS: all 3 fixes are correct and scoped to exactly the lines identified in the issue.
Terraform: comment-only addition, no functional change to args. tofu validate confirmed passing.
No remaining off-palette hex values found in full CSS file scan (all 40+ hex values match the 10 design tokens).

Nits

None. Clean PR.

VERDICT: APPROVE

## QA Review — PR #208 ### Acceptance Criteria Check (from issue #131) | Criteria | Status | Notes | |----------|--------|-------| | No off-palette colors | PASS | All hex values traceable to design tokens in header comment. `#1a1a1a` replaced with `#262626` (--color-gray-800). | | Border renders as red top only | PASS | Redundant `border-color: #d42026` removed. Only `border-top: 4px solid #d42026` remains. | | Font size uses rem units | PASS | `29px` converted to `1.8125rem` with conversion comment. | | Cache flags documented | PASS | TODO(production) comment added with explanation of each flag. Flags left functional — consistent with issue constraint ("removal may be deferred"). | ### Diff Review - **2 files changed**, +6/-4 lines. Minimal, focused diff — no unrelated changes. - CSS: all 3 fixes are correct and scoped to exactly the lines identified in the issue. - Terraform: comment-only addition, no functional change to args. `tofu validate` confirmed passing. - No remaining off-palette hex values found in full CSS file scan (all 40+ hex values match the 10 design tokens). ### Nits None. Clean PR. --- **VERDICT: APPROVE**