fix: remove unreachable pal-e-docs refs, add claude-code-guide spawn type

forgejo_admin commented

2026-03-15 01:47:31 +00:00

Contributor

Summary

Remove unreachable mcp__pal-e-docs__get_note profile lines from 6 agent configs that lack pal-e-docs MCP access, and add the claude-code-guide entry to the agent spawn requirements schema.

Changes

agents/dev-backend.md — removed unreachable profile intro + get_note line
agents/dev-frontend.md — removed unreachable profile intro + get_note line
agents/devops.md — removed unreachable profile intro + get_note line
agents/dev-qa.md — removed unreachable profile intro + get_note line
agents/devops-qa.md — removed unreachable profile intro + get_note line
agents/frontend-qa.md — removed unreachable profile intro + get_note line
schemas/agent-spawn-requirements.json — added claude-code-guide type (no gate, no isolation, produces analysis)

Test Plan

jq . schemas/agent-spawn-requirements.json validates cleanly
grep -r "mcp__pal-e-docs__get_note" agents/ returns zero matches (dottie.md does not use this pattern)
Spawn hook should accept claude-code-guide agent without requiring issue/PR refs

Review Checklist

No unreachable MCP calls remain in non-docs agents
dottie.md untouched (has pal-e-docs access)
JSON schema validates with jq
claude-code-guide entry follows Explore pattern (no gate, produces analysis)

Closes #105

## Summary Remove unreachable `mcp__pal-e-docs__get_note` profile lines from 6 agent configs that lack pal-e-docs MCP access, and add the `claude-code-guide` entry to the agent spawn requirements schema. ## Changes - `agents/dev-backend.md` — removed unreachable profile intro + get_note line - `agents/dev-frontend.md` — removed unreachable profile intro + get_note line - `agents/devops.md` — removed unreachable profile intro + get_note line - `agents/dev-qa.md` — removed unreachable profile intro + get_note line - `agents/devops-qa.md` — removed unreachable profile intro + get_note line - `agents/frontend-qa.md` — removed unreachable profile intro + get_note line - `schemas/agent-spawn-requirements.json` — added `claude-code-guide` type (no gate, no isolation, produces analysis) ## Test Plan - `jq . schemas/agent-spawn-requirements.json` validates cleanly - `grep -r "mcp__pal-e-docs__get_note" agents/` returns zero matches (dottie.md does not use this pattern) - Spawn hook should accept `claude-code-guide` agent without requiring issue/PR refs ## Review Checklist - [x] No unreachable MCP calls remain in non-docs agents - [x] dottie.md untouched (has pal-e-docs access) - [x] JSON schema validates with jq - [x] claude-code-guide entry follows Explore pattern (no gate, produces analysis) ## Related - Closes #105

forgejo_admin added 1 commit

2026-03-15 01:47:31 +00:00

fix: remove unreachable pal-e-docs profile refs from 6 agents, add claude-code-guide spawn type 0e847e86ec

Remove the "Read your full profile" + mcp__pal-e-docs__get_note lines from
dev-backend, dev-frontend, devops, dev-qa, devops-qa, and frontend-qa agent
configs. These agents lack pal-e-docs MCP access so the call always fails.

Add claude-code-guide entry to agent-spawn-requirements.json with no gate
(read-only, no isolation needed).

Closes #105

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

forgejo_admin commented

2026-03-15 01:49:38 +00:00

Author

Contributor

PR #106 Review

DOMAIN REVIEW

This PR touches agent configuration files (Markdown frontmatter + body) and a JSON spawn-requirements schema. No Terraform, k8s, Salt, or ArgoCD changes.

Agent config removals (6 files): Each of the 6 agents (dev-backend, dev-frontend, devops, dev-qa, devops-qa, frontend-qa) had a 3-line block removed:

You are the {Agent} agent. Read your full profile:
`mcp__pal-e-docs__get_note(slug="agent-{name}")`

Verified: None of these 6 agents list pal-e-docs in their mcpServers frontmatter, so these get_note calls were unreachable dead code. The two agents that DO have pal-e-docs access (dottie.md via pal-e-docs in mcpServers, betty-sue.md via same) were correctly left untouched. Post-PR grep of agents/ for mcp__pal-e-docs__get_note returns zero matches -- clean.

Schema addition (claude-code-guide): Follows the exact same structure as the existing Explore type:

required_patterns: [] -- no gate, appropriate for a read-only help agent
produces: ["analysis"] -- correct, it only produces analysis output
isolation: false -- appropriate since it doesn't create branches or PRs (differs from Explore which has isolation: true, but this is intentional since claude-code-guide doesn't write to repos at all)

JSON structure is well-formed. Trailing comma placement is correct (added comma after the closing brace of Explore, new entry is the last element before the closing braces).

BLOCKERS

None.

NITS

isolation difference between Explore and claude-code-guide: Explore has isolation: true while claude-code-guide has isolation: false. Both are described as read-only. If claude-code-guide is truly read-only, isolation: false is fine (no worktree overhead for a help query). But worth noting the inconsistency for future reference -- if the spawn hook treats isolation as a security boundary rather than just a resource optimization, the two should align. Non-blocking since the PR description explicitly calls this out ("No gate, no isolation, produces analysis").

SOP COMPLIANCE

Branch named after issue (105-fix-remove-unreachable-pal-e-docs-refs-a references #105)
PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related)
Closes #105 present in Related section
No secrets, .env files, or credentials committed
No unnecessary file changes -- scope is tight (6 agent configs + 1 schema, exactly as described)
No Terraform changes, so tofu plan output not applicable
Related section does not reference a plan slug (should reference plan-pal-e-agency Phase 12v per the task description)

PROCESS OBSERVATIONS

Low-risk change: removing dead code and adding a schema entry. Zero deployment impact -- these are local Claude Code agent configs, not infrastructure.
The unreachable get_note lines were likely a holdover from when agents were first created. Good hygiene to clean them up -- they could confuse agents into attempting MCP calls that would fail at runtime.
The missing plan slug reference in the Related section is a minor process gap. Including plan-pal-e-agency Phase 12v would maintain traceability from PR to plan.

VERDICT: APPROVED

## PR #106 Review ### DOMAIN REVIEW This PR touches agent configuration files (Markdown frontmatter + body) and a JSON spawn-requirements schema. No Terraform, k8s, Salt, or ArgoCD changes. **Agent config removals (6 files):** Each of the 6 agents (`dev-backend`, `dev-frontend`, `devops`, `dev-qa`, `devops-qa`, `frontend-qa`) had a 3-line block removed: ``` You are the {Agent} agent. Read your full profile: `mcp__pal-e-docs__get_note(slug="agent-{name}")` ``` Verified: None of these 6 agents list `pal-e-docs` in their `mcpServers` frontmatter, so these `get_note` calls were unreachable dead code. The two agents that DO have pal-e-docs access (`dottie.md` via `pal-e-docs` in mcpServers, `betty-sue.md` via same) were correctly left untouched. Post-PR grep of `agents/` for `mcp__pal-e-docs__get_note` returns zero matches -- clean. **Schema addition (`claude-code-guide`):** Follows the exact same structure as the existing `Explore` type: - `required_patterns: []` -- no gate, appropriate for a read-only help agent - `produces: ["analysis"]` -- correct, it only produces analysis output - `isolation: false` -- appropriate since it doesn't create branches or PRs (differs from `Explore` which has `isolation: true`, but this is intentional since claude-code-guide doesn't write to repos at all) JSON structure is well-formed. Trailing comma placement is correct (added comma after the closing brace of `Explore`, new entry is the last element before the closing braces). ### BLOCKERS None. ### NITS 1. **`isolation` difference between `Explore` and `claude-code-guide`**: `Explore` has `isolation: true` while `claude-code-guide` has `isolation: false`. Both are described as read-only. If `claude-code-guide` is truly read-only, `isolation: false` is fine (no worktree overhead for a help query). But worth noting the inconsistency for future reference -- if the spawn hook treats `isolation` as a security boundary rather than just a resource optimization, the two should align. Non-blocking since the PR description explicitly calls this out ("No gate, no isolation, produces analysis"). ### SOP COMPLIANCE - [x] Branch named after issue (`105-fix-remove-unreachable-pal-e-docs-refs-a` references #105) - [x] PR body follows template (Summary, Changes, Test Plan, Review Checklist, Related) - [x] `Closes #105` present in Related section - [x] No secrets, .env files, or credentials committed - [x] No unnecessary file changes -- scope is tight (6 agent configs + 1 schema, exactly as described) - [x] No Terraform changes, so `tofu plan` output not applicable - [ ] Related section does not reference a plan slug (should reference `plan-pal-e-agency` Phase 12v per the task description) ### PROCESS OBSERVATIONS - Low-risk change: removing dead code and adding a schema entry. Zero deployment impact -- these are local Claude Code agent configs, not infrastructure. - The unreachable `get_note` lines were likely a holdover from when agents were first created. Good hygiene to clean them up -- they could confuse agents into attempting MCP calls that would fail at runtime. - The missing plan slug reference in the Related section is a minor process gap. Including `plan-pal-e-agency` Phase 12v would maintain traceability from PR to plan. ### VERDICT: APPROVED