Audit and cleanup: commit recent work, purge GitHub-era cruft (#36)

forgejo_admin commented

2026-03-01 05:02:44 +00:00

Contributor

Summary

Commits 3 days of uncommitted work (Betty Sue personality, hook improvements, MCP server config)
Removes 63 dead files (8,250 lines) of GitHub-era cruft carried over from the Feb 22-23 fork

Changes

CLAUDE.md: Rewrite from Devy to Betty Sue personality
hooks/check-agent-spawn.sh: Allow project-* refs in addition to plan-*
hooks/session-start-context.sh: Add personality injection from pal-e-docs
settings.local.json: Switch MCP servers to notion, pal-e-docs, forgejo
plugins/blocklist.json, plugins/known_marketplaces.json: Auto-generated cache updates
Deleted: agents/nvim-minion/, docs/, dotfiles/, github/, patterns/, projects/, commands/

Test Plan

Verify symlinks still work: ls -la ~/.claude/CLAUDE.md shows Betty Sue content
Verify hooks fire: start new session, confirm personality injection
Verify no broken references to deleted dirs

Review Checklist

Passed automated review-fix loop
No secrets committed
No unnecessary file changes
Commit messages are descriptive

Issue #36 — Audit and cleanup
project-ai-agency — the AI agency project
plan-2026-02-25-agent-profiles — agent profiles plan

## Summary - Commits 3 days of uncommitted work (Betty Sue personality, hook improvements, MCP server config) - Removes 63 dead files (8,250 lines) of GitHub-era cruft carried over from the Feb 22-23 fork ## Changes - `CLAUDE.md`: Rewrite from Devy to Betty Sue personality - `hooks/check-agent-spawn.sh`: Allow `project-*` refs in addition to `plan-*` - `hooks/session-start-context.sh`: Add personality injection from pal-e-docs - `settings.local.json`: Switch MCP servers to notion, pal-e-docs, forgejo - `plugins/blocklist.json`, `plugins/known_marketplaces.json`: Auto-generated cache updates - Deleted: `agents/nvim-minion/`, `docs/`, `dotfiles/`, `github/`, `patterns/`, `projects/`, `commands/` ## Test Plan - [ ] Verify symlinks still work: `ls -la ~/.claude/CLAUDE.md` shows Betty Sue content - [ ] Verify hooks fire: start new session, confirm personality injection - [ ] Verify no broken references to deleted dirs ## Review Checklist - [ ] Passed automated review-fix loop - [ ] No secrets committed - [ ] No unnecessary file changes - [ ] Commit messages are descriptive ## Related Notes - Issue #36 — Audit and cleanup - `project-ai-agency` — the AI agency project - `plan-2026-02-25-agent-profiles` — agent profiles plan

forgejo_admin added 3 commits

2026-03-01 05:02:44 +00:00

Commit recent work: Betty Sue personality, hook improvements (#36 ) 304c7798b5

- CLAUDE.md: Rewrite from Devy to Betty Sue personality, thin down to
  essentials (personality lives in pal-e-docs now)
- check-agent-spawn.sh: Allow project-* refs in addition to plan-*
- session-start-context.sh: Add personality injection from pal-e-docs
- settings.local.json: Switch MCP servers to notion, pal-e-docs, forgejo

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update auto-generated plugin cache files (#36 ) a1f06aec65

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove GitHub-era cruft: agents, docs, dotfiles, patterns, projects, commands (#36 ) 4e3230e232

All of these were carried over from the GitHub claude-custom fork on Feb 22-23
and never touched since. They are superseded by the Forgejo-native architecture:

- agents/nvim-minion — agent profiles live in pal-e-docs now
- docs/ — best-practices and config notes superseded by pal-e-docs
- dotfiles/ — old index.json, irrelevant
- github/ — old GitHub index.json, we're on Forgejo now
- patterns/ — old orchestration patterns, docker templates, nvim-agent template
- projects/ — macOS-era project configs with -Users-ldraney paths
- commands/ — old Monday.com formula commands, skills replaced this

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

forgejo_admin commented

2026-03-01 05:07:00 +00:00

Author

Contributor

PR #37 Review

BLOCKERS

None. The changes are clean and well-scoped.

NITS

plugins/known_marketplaces.json contains macOS path (line 7): installLocation references /Users/ldraney/.claude/plugins/marketplaces/claude-plugins-official -- this is a macOS path in what is now a Linux (Arch) environment. This file is auto-generated by Claude Code, so it may self-correct, but it's worth noting that this is leftover from the macOS era. Non-blocking since it's auto-generated cache.
settings.local.json contains stale macOS/Fly.io references (pre-existing, not introduced by this PR): Line 19 has Bash(/Users/ldraney/fly/tamara-health-check.sh:*) and multiple Bash(fly ...:*) permissions for a Fly.io workflow that appears defunct. These are GitHub-era cruft in the permissions list that survived the cleanup. Consider addressing in a follow-up issue.
settings.json has potentially stale enabledMcpjsonServers (pre-existing): agent-manager, mcp-nvim, ts-tools, nvim-helper, ableton are listed but may be GitHub-era remnants. Same follow-up recommendation.
Review Checklist items all unchecked: The PR body's ## Review Checklist has all 4 items unchecked ([ ]). Ideally the Dev agent checks these before submitting. Non-blocking for a cleanup PR.
Related Notes uses Issue #36 instead of a note slug: The template-pr-body specifies note slugs in backticks (e.g., issue-slug). The PR body uses Issue #36 -- Audit and cleanup which is a Forgejo issue reference, not a pal-e-docs note slug. This is a minor template deviation. The plan slug is correctly referenced.

SOP COMPLIANCE

Branch named after issue number -- 36-audit-and-cleanup-commit-recent-work-rem starts with 36, matching issue #36
PR body follows template-pr-body -- All 5 required sections present: Summary, Changes, Test Plan, Review Checklist, Related Notes
Related Notes references the plan slug -- plan-2026-02-25-agent-profiles correctly referenced
No secrets, .env files, or credentials committed -- Verified: no actual secrets in diff. References to ~/secrets/ are path references only (pre-existing in forgejo-helper.sh and CLAUDE.md), not credential values
No unnecessary file changes (scope creep) -- All changes align with the issue scope: (1) committing recent work (CLAUDE.md, hooks, settings, new skill), (2) auto-generated plugin cache updates, (3) deleting GitHub-era cruft. The new hooks (remind-update-docs.sh, stop-doc-checkin.sh) and skills/plan/SKILL.md are part of the "3 days of uncommitted work" being committed, which is within scope
Commit messages are descriptive -- All 3 commits have clear, descriptive messages referencing issue #36:
- Commit recent work: Betty Sue personality, hook improvements (#36)
- Update auto-generated plugin cache files (#36)
- Remove GitHub-era cruft: agents, docs, dotfiles, patterns, projects, commands (#36)
Tests exist and pass -- No tests applicable (config/hook repo, no test framework). Acceptable for this repo type.
Passed automated review-fix loop -- Checklist unchecked in PR body. This appears to be the first review round.

VERDICT: APPROVED

Clean, well-organized cleanup PR. The 3-commit structure (new work, auto-generated updates, deletions) is logical and easy to review. No secrets, no scope creep, no correctness issues in the code changes. The nits about stale macOS paths in settings.local.json and settings.json are pre-existing and could be addressed in a follow-up cleanup issue.

## PR #37 Review ### BLOCKERS None. The changes are clean and well-scoped. ### NITS 1. **`plugins/known_marketplaces.json` contains macOS path** (line 7): `installLocation` references `/Users/ldraney/.claude/plugins/marketplaces/claude-plugins-official` -- this is a macOS path in what is now a Linux (Arch) environment. This file is auto-generated by Claude Code, so it may self-correct, but it's worth noting that this is leftover from the macOS era. Non-blocking since it's auto-generated cache. 2. **`settings.local.json` contains stale macOS/Fly.io references** (pre-existing, not introduced by this PR): Line 19 has `Bash(/Users/ldraney/fly/tamara-health-check.sh:*)` and multiple `Bash(fly ...:*)` permissions for a Fly.io workflow that appears defunct. These are GitHub-era cruft in the permissions list that survived the cleanup. Consider addressing in a follow-up issue. 3. **`settings.json` has potentially stale `enabledMcpjsonServers`** (pre-existing): `agent-manager`, `mcp-nvim`, `ts-tools`, `nvim-helper`, `ableton` are listed but may be GitHub-era remnants. Same follow-up recommendation. 4. **Review Checklist items all unchecked**: The PR body's `## Review Checklist` has all 4 items unchecked (`[ ]`). Ideally the Dev agent checks these before submitting. Non-blocking for a cleanup PR. 5. **`Related Notes` uses `Issue #36` instead of a note slug**: The `template-pr-body` specifies note slugs in backticks (e.g., `issue-slug`). The PR body uses `Issue #36 -- Audit and cleanup` which is a Forgejo issue reference, not a pal-e-docs note slug. This is a minor template deviation. The plan slug is correctly referenced. ### SOP COMPLIANCE - [x] **Branch named after issue number** -- `36-audit-and-cleanup-commit-recent-work-rem` starts with `36`, matching issue #36 - [x] **PR body follows `template-pr-body`** -- All 5 required sections present: Summary, Changes, Test Plan, Review Checklist, Related Notes - [x] **Related Notes references the plan slug** -- `plan-2026-02-25-agent-profiles` correctly referenced - [x] **No secrets, .env files, or credentials committed** -- Verified: no actual secrets in diff. References to `~/secrets/` are path references only (pre-existing in `forgejo-helper.sh` and `CLAUDE.md`), not credential values - [x] **No unnecessary file changes (scope creep)** -- All changes align with the issue scope: (1) committing recent work (CLAUDE.md, hooks, settings, new skill), (2) auto-generated plugin cache updates, (3) deleting GitHub-era cruft. The new hooks (`remind-update-docs.sh`, `stop-doc-checkin.sh`) and `skills/plan/SKILL.md` are part of the "3 days of uncommitted work" being committed, which is within scope - [x] **Commit messages are descriptive** -- All 3 commits have clear, descriptive messages referencing issue #36: - `Commit recent work: Betty Sue personality, hook improvements (#36)` - `Update auto-generated plugin cache files (#36)` - `Remove GitHub-era cruft: agents, docs, dotfiles, patterns, projects, commands (#36)` - [ ] **Tests exist and pass** -- No tests applicable (config/hook repo, no test framework). Acceptable for this repo type. - [ ] **Passed automated review-fix loop** -- Checklist unchecked in PR body. This appears to be the first review round. ### VERDICT: APPROVED Clean, well-organized cleanup PR. The 3-commit structure (new work, auto-generated updates, deletions) is logical and easy to review. No secrets, no scope creep, no correctness issues in the code changes. The nits about stale macOS paths in `settings.local.json` and `settings.json` are pre-existing and could be addressed in a follow-up cleanup issue.