ldraney/landscaping-assistant
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions 4

Add deactivate button to properties on Today tab #24

Closed
ldraney wants to merge 1 commit from deactivate-from-today into main
pull from: deactivate-from-today
merge into: ldraney:main
Conversation 0 Commits 1 Files changed 3 +70 -24
ldraney commented 2026-05-25 03:26:19 +00:00
Owner
Copy link

Summary

Properties in the All Properties list on the Today tab can now be deactivated with an X button. The property is removed from the list via Turbo Stream.

Changes

  • Added X deactivate button next to each property's add/queued button
  • Updated turbo stream template to remove property from Today list on deactivation
  • Subtle muted X turns red on hover, doesn't compete with the add button visually

Test Plan

  • Deactivate button renders on all properties in Today tab
  • Clicking X removes property from list via Turbo Stream
  • Property shows as inactive on Properties (manage) tab
  • Re-activating on Properties tab makes it reappear on Today

Review Checklist

  • No Tailwind
  • Turbo Stream handles both manage and today contexts
  • CSS uses design tokens

Related Notes

Closes #8
Tested on dev at landscaping-dev.tail5b443a.ts.net

## Summary Properties in the All Properties list on the Today tab can now be deactivated with an X button. The property is removed from the list via Turbo Stream. ## Changes - Added X deactivate button next to each property's add/queued button - Updated turbo stream template to remove property from Today list on deactivation - Subtle muted X turns red on hover, doesn't compete with the add button visually ## Test Plan - [x] Deactivate button renders on all properties in Today tab - [x] Clicking X removes property from list via Turbo Stream - [ ] Property shows as inactive on Properties (manage) tab - [ ] Re-activating on Properties tab makes it reappear on Today ## Review Checklist - [x] No Tailwind - [x] Turbo Stream handles both manage and today contexts - [x] CSS uses design tokens ## Related Notes Closes #8 Tested on dev at landscaping-dev.tail5b443a.ts.net
Add deactivate button to properties on Today tab
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
CI / scan_ruby (pull_request) Has been cancelled
Details
CI / scan_js (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details
bf059a2cf1 
X button on each property in All Properties list toggles it inactive.
Property is removed from the list via Turbo Stream since Today only
shows active properties. Subtle muted X turns red on hover.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ldraney closed this pull request 2026-06-01 07:33:49 +00:00
Some checks failed
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
CI / scan_ruby (pull_request) Has been cancelled
Details
CI / scan_js (pull_request) Has been cancelled
Details
CI / lint (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ldraney/landscaping-assistant!24
No description provided.